comphead commented on code in PR #18985:
URL: https://github.com/apache/datafusion/pull/18985#discussion_r2585939870
##########
benchmarks/bench.sh:
##########
@@ -597,6 +607,14 @@ data_tpch() {
fi
}
+# Points to TPCDS data generation instructions
+data_tpcds() {
+ echo ""
+ echo "For TPC-DS data generation, please clone the datafusion-benchmarks
repository:"
Review Comment:
I dont know how to do it better tbh, TPCDS generation is quite complicated
if you dont own `dsdgen` which needs to be personally downloaded and built.
the expected flow to run benches with `data` then with benchmark `run` and
since we dont gen data itself for TPCDS I just left an instructions how to get
the data.
Let me know if you feel that other way would more fit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
