alamb commented on code in PR #18946:
URL: https://github.com/apache/datafusion/pull/18946#discussion_r2589551287
##########
ci/scripts/rust_example.sh:
##########
@@ -25,12 +25,26 @@ export CARGO_PROFILE_CI_STRIP=true
cd datafusion-examples/examples/
cargo build --profile ci --examples
-files=$(ls .)
-for filename in $files
-do
- example_name=`basename $filename ".rs"`
- # Skip tests that rely on external storage and flight
- if [ ! -d $filename ]; then
- cargo run --profile ci --example $example_name
- fi
+SKIP_LIST=("external_dependency" "flight" "ffi")
+
+skip_example() {
+ local name="$1"
+ for skip in "${SKIP_LIST[@]}"; do
+ if [ "$name" = "$skip" ]; then
+ return 0
+ fi
+ done
+ return 1
+}
+
+for dir in */; do
+ example_name=$(basename "$dir")
+
+ if skip_example "$example_name"; then
+ echo "Skipping $example_name"
+ continue
+ fi
+
+ echo "Running example group: $example_name"
Review Comment:
I think the issue is that some of the examples leave files around:
```shell
andrewlamb@Andrews-MacBook-Pro-3:~/Software/datafusion2$ find
datafusion-examples/examples/datafusion-examples
datafusion-examples/examples/datafusion-examples
datafusion-examples/examples/datafusion-examples/test_json
datafusion-examples/examples/datafusion-examples/test_json/lQqU6IGDpwHJyGQB_0.json
datafusion-examples/examples/datafusion-examples/test_json/KKsELYFJ4st3GUOa_0.json
datafusion-examples/examples/datafusion-examples/test_csv
datafusion-examples/examples/datafusion-examples/test_csv/9Alj5dF7w72vLpp0_0.csv.gz
datafusion-examples/examples/datafusion-examples/test_csv/4Bh8tCQllXXE43A9_0.csv.gz
datafusion-examples/examples/datafusion-examples/test_table
datafusion-examples/examples/datafusion-examples/test_table/Y2CVyUXOXRPhDhFA_0.parquet
datafusion-examples/examples/datafusion-examples/test_table/2nskzCtDZnEJR851_0.parquet
datafusion-examples/examples/datafusion-examples/test_parquet
datafusion-examples/examples/datafusion-examples/test_parquet/4CIKeX6U9Ik1YYgY_0.parquet
datafusion-examples/examples/datafusion-examples/test_parquet/ooUJiB7QMqY0BRdN_0.parquet
```
Maybe we could change the examples to use a temporary directory or else have
this script clean up before running
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
