adriangb commented on code in PR #19128:
URL: https://github.com/apache/datafusion/pull/19128#discussion_r2594873292
##########
datafusion/physical-expr/src/simplifier/mod.rs:
##########
@@ -47,15 +44,30 @@ impl<'a> PhysicalExprSimplifier<'a> {
}
/// Simplify a physical expression
- pub fn simplify(
- &mut self,
- expr: Arc<dyn PhysicalExpr>,
- ) -> Result<Arc<dyn PhysicalExpr>> {
+ pub fn simplify(&self, expr: Arc<dyn PhysicalExpr>) -> Result<Arc<dyn
PhysicalExpr>> {
Review Comment:
This is backwards compatible (aside from compiler warnings that the variable
doesn't need to be mutable) and means we can keep multiple references, arc it,
etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
