adriangb commented on code in PR #19140:
URL: https://github.com/apache/datafusion/pull/19140#discussion_r2596242704
##########
datafusion/execution/src/cache/list_files_cache.rs:
##########
@@ -55,6 +75,19 @@ impl DefaultListFilesCache {
pub fn new(memory_limit: usize, ttl: Option<Duration>) -> Self {
Self {
state: Mutex::new(DefaultListFilesCacheState::new(memory_limit,
ttl)),
+ time_provider: Arc::new(SystemTimeProvider),
+ }
+ }
+
+ #[cfg(test)]
+ pub fn new_with_provider(
Review Comment:
I understand the point, either seems fine to me, I’d opt for the less
verbose / repetitive version here, I don’t think the interaction with the
system clock is problematic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
