adriangb commented on code in PR #19188:
URL: https://github.com/apache/datafusion/pull/19188#discussion_r2596556201
##########
datafusion/physical-expr/src/expressions/dynamic_filters.rs:
##########
@@ -415,6 +415,13 @@ impl PhysicalExpr for DynamicFilterPhysicalExpr {
// Return the current generation of the expression.
self.inner.read().generation
}
+
+ fn node_volatility(&self) -> ExprVolatility {
+ // Although DynamicFilterPhysicalExpr can change its inner expression,
+ // from the perspective of optimizer rules it can be treated as
immutable
+ // so that it can be pushed down, etc.
+ ExprVolatility::Immutable
+ }
Review Comment:
This is unfortunate, but I'm not sure how else to model this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
