geoffreyclaude commented on PR #18832:
URL: https://github.com/apache/datafusion/pull/18832#issuecomment-3625839469
General comment on the benchmark but... am I reading them wrong, or is the
`null_percent` input logic inverted?
```rust
fn do_benches(
c: &mut Criterion,
array_length: usize,
in_list_length: usize,
null_percent: f64,
) {
...
let values: Int32Array = (0..array_length)
.map(|_| rng.random_bool(null_percent).then(|| rng.random()))
.collect();
let in_list: Vec<_> = (0..in_list_length)
.map(|_| ScalarValue::Int32(Some(rng.random())))
.collect();
do_bench(
c,
&format!("in_list_i32 ({array_length}, {null_percent}) IN
({in_list_length}, 0)"),
Arc::new(values),
&in_list,
)
```
When `null_percent` is `0`, won't this just create a `array_length` long
`values` array of `NULL`s?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
