chakkk309 commented on code in PR #19133:
URL: https://github.com/apache/datafusion/pull/19133#discussion_r2598342580
##########
datafusion/core/src/lib.rs:
##########
@@ -35,7 +36,7 @@
)
)]
#![warn(missing_docs, clippy::needless_borrow)]
-#![cfg_attr(test, allow(clippy::needless_pass_by_value))]
+#![cfg_attr(test, expect(clippy::needless_pass_by_value))]
Review Comment:
Not required, but i think the `expect` gives us better feedback when code
improves.
##########
datafusion/core/src/lib.rs:
##########
@@ -35,7 +36,7 @@
)
)]
#![warn(missing_docs, clippy::needless_borrow)]
-#![cfg_attr(test, allow(clippy::needless_pass_by_value))]
+#![cfg_attr(test, expect(clippy::needless_pass_by_value))]
Review Comment:
Not required here, but i think the `expect` gives us better feedback when
code improves.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
