Jefffrey commented on code in PR #19133:
URL: https://github.com/apache/datafusion/pull/19133#discussion_r2596775889
##########
datafusion/core/src/lib.rs:
##########
@@ -35,7 +36,7 @@
)
)]
#![warn(missing_docs, clippy::needless_borrow)]
-#![cfg_attr(test, allow(clippy::needless_pass_by_value))]
+#![cfg_attr(test, expect(clippy::needless_pass_by_value))]
Review Comment:
Is changing the allow to expect is strictly necessary here?
##########
datafusion/proto-common/src/generated/mod.rs:
##########
@@ -15,7 +15,6 @@
// specific language governing permissions and limitations
// under the License.
-#[allow(clippy::all)]
Review Comment:
I wonder if it would be better to leave this, considering its for generated
code 🤔
##########
datafusion/catalog-listing/src/mod.rs:
##########
@@ -15,7 +15,7 @@
// specific language governing permissions and limitations
// under the License.
-#![cfg_attr(test, allow(clippy::needless_pass_by_value))]
Review Comment:
Is removing the existing allow for needless_pass_by_value in tests
intentional?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
