alamb commented on code in PR #19244:
URL: https://github.com/apache/datafusion/pull/19244#discussion_r2612246921
##########
benchmarks/bench.sh:
##########
@@ -631,20 +631,22 @@ data_tpch() {
# Points to TPCDS data generation instructions
data_tpcds() {
- TPCDS_DIR="${DATA_DIR}"
-
- # Check if TPCDS data directory exists
- if [ ! -d "${TPCDS_DIR}" ]; then
- echo ""
- echo "For TPC-DS data generation, please clone the
datafusion-benchmarks repository:"
- echo " git clone https://github.com/apache/datafusion-benchmarks";
- echo ""
- return 1
+ TPCDS_DIR="${DATA_DIR}/tpcds_sf1"
+
+ # Check if `web_site.parquet` exists in the TPCDS data directory to verify
data presence
+ echo "Checking TPC-DS data directory: ${TPCDS_DIR}"
+ if [ ! -f "${TPCDS_DIR}/web_site.parquet" ]; then
+ mkdir -p "${TPCDS_DIR}"
+ # Download the DataFusion benchmarks repository zip if it is not
already downloaded
+ if [ ! -f "${DATA_DIR}/datafusion-benchmarks.zip" ]; then
+ echo "Downloading DataFusion benchmarks repository zip to:
${DATA_DIR}/datafusion-benchmarks.zip"
+ wget -O "${DATA_DIR}/datafusion-benchmarks.zip"
https://github.com/apache/datafusion-benchmarks/archive/refs/heads/main.zip
Review Comment:
This this is true. However, the downside is that then the script would
require git to be configured and check out the whole repository (I couldn't
find any way to get it to extract just a sub directory). But then again maybe
that is no worse than a zipfile 🤔 On the other hand the tpcds dataset should
never change 🤔
Since this method seems to work, I will go with the wget approach for now
and we could change it in a follow on PR if desired
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
