alamb commented on code in PR #19244:
URL: https://github.com/apache/datafusion/pull/19244#discussion_r2612253410
##########
benchmarks/bench.sh:
##########
@@ -631,20 +631,22 @@ data_tpch() {
# Points to TPCDS data generation instructions
data_tpcds() {
- TPCDS_DIR="${DATA_DIR}"
-
- # Check if TPCDS data directory exists
- if [ ! -d "${TPCDS_DIR}" ]; then
- echo ""
- echo "For TPC-DS data generation, please clone the
datafusion-benchmarks repository:"
- echo " git clone https://github.com/apache/datafusion-benchmarks";
- echo ""
- return 1
+ TPCDS_DIR="${DATA_DIR}/tpcds_sf1"
Review Comment:
This is a good idea and it would avoid deuplication. However, none of the
other datasets follow this pattern (they all duplicate the paths), so in this
case I would prefer to keep the code consistent (we can refactor the common
locations into variables as a follow on PR if we want)
##########
benchmarks/bench.sh:
##########
@@ -631,20 +631,22 @@ data_tpch() {
# Points to TPCDS data generation instructions
data_tpcds() {
- TPCDS_DIR="${DATA_DIR}"
-
- # Check if TPCDS data directory exists
- if [ ! -d "${TPCDS_DIR}" ]; then
- echo ""
- echo "For TPC-DS data generation, please clone the
datafusion-benchmarks repository:"
- echo " git clone https://github.com/apache/datafusion-benchmarks";
- echo ""
- return 1
+ TPCDS_DIR="${DATA_DIR}/tpcds_sf1"
+
+ # Check if `web_site.parquet` exists in the TPCDS data directory to verify
data presence
+ echo "Checking TPC-DS data directory: ${TPCDS_DIR}"
+ if [ ! -f "${TPCDS_DIR}/web_site.parquet" ]; then
Review Comment:
Same as above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
