timsaucer commented on code in PR #19281:
URL: https://github.com/apache/datafusion/pull/19281#discussion_r2613490245
##########
datafusion/ffi/src/table_provider.rs:
##########
@@ -194,17 +189,16 @@ unsafe extern "C" fn table_type_fn_wrapper(
fn supports_filters_pushdown_internal(
provider: &Arc<dyn TableProvider + Send>,
filters_serialized: &[u8],
+ task_ctx: &Arc<TaskContext>,
+ codec: &dyn LogicalExtensionCodec,
) -> Result<RVec<FFI_TableProviderFilterPushDown>> {
- let default_ctx = SessionContext::new();
- let codec = DefaultLogicalExtensionCodec {};
-
Review Comment:
Here is the main thrust of this work. In this place and others we no longer
rely on creating a default SessionContext and codec.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
