timsaucer commented on code in PR #19281:
URL: https://github.com/apache/datafusion/pull/19281#discussion_r2613592656
##########
datafusion/ffi/src/plan_properties.rs:
##########
@@ -92,15 +78,8 @@ impl FFI_PlanProperties {
unsafe extern "C" fn output_partitioning_fn_wrapper(
properties: &FFI_PlanProperties,
-) -> FFIResult<RVec<u8>> {
- let codec = DefaultPhysicalExtensionCodec {};
- let partitioning_data = rresult_return!(serialize_partitioning(
- properties.inner().output_partitioning(),
- &codec
- ));
- let output_partitioning = partitioning_data.encode_to_vec();
-
- ROk(output_partitioning.into())
Review Comment:
Here is one of the big wins on the physical side - no longer using the
protobuf serialization.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
