DoumanAsh commented on code in PR #19262:
URL: https://github.com/apache/datafusion/pull/19262#discussion_r2613691335
##########
datafusion/datasource-csv/src/source.rs:
##########
@@ -453,16 +453,17 @@ pub async fn plan_to_csv(
let parsed = ListingTableUrl::parse(path)?;
let object_store_url = parsed.object_store();
let store = task_ctx.runtime_env().object_store(&object_store_url)?;
- let writer_buffer_size = task_ctx
- .session_config()
- .options()
- .execution
- .objectstore_writer_buffer_size;
+ let exec_options = &task_ctx.session_config().options().execution;
+ let writer_buffer_size = exec_options.objectstore_writer_buffer_size;
let mut join_set = JoinSet::new();
for i in 0..plan.output_partitioning().partition_count() {
let storeref = Arc::clone(&store);
let plan: Arc<dyn ExecutionPlan> = Arc::clone(&plan);
- let filename = format!("{}/part-{i}.csv", parsed.prefix());
+ let filename = format!(
+ "{}/{}part-{i}.csv",
+ exec_options.partitioned_file_prefix_name,
+ parsed.prefix()
+ );
Review Comment:
Thank you, applied
I also refactored it to embed explicit name rather than using parameters to
avoid such error
##########
datafusion/datasource-json/src/source.rs:
##########
@@ -275,16 +275,17 @@ pub async fn plan_to_json(
let parsed = ListingTableUrl::parse(path)?;
let object_store_url = parsed.object_store();
let store = task_ctx.runtime_env().object_store(&object_store_url)?;
- let writer_buffer_size = task_ctx
- .session_config()
- .options()
- .execution
- .objectstore_writer_buffer_size;
+ let exec_options = &task_ctx.session_config().options().execution;
+ let writer_buffer_size = exec_options.objectstore_writer_buffer_size;
let mut join_set = JoinSet::new();
for i in 0..plan.output_partitioning().partition_count() {
let storeref = Arc::clone(&store);
let plan: Arc<dyn ExecutionPlan> = Arc::clone(&plan);
- let filename = format!("{}/part-{i}.json", parsed.prefix());
+ let filename = format!(
+ "{}/{}part-{i}.json",
+ exec_options.partitioned_file_prefix_name,
+ parsed.prefix()
+ );
Review Comment:
Applied
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
