ethan-tyler commented on code in PR #19262:
URL: https://github.com/apache/datafusion/pull/19262#discussion_r2615374168
##########
datafusion/datasource/src/write/demux.rs:
##########
@@ -156,7 +156,8 @@ async fn row_count_demuxer(
let max_buffered_batches =
exec_options.max_buffered_batches_per_output_file;
let minimum_parallel_files = exec_options.minimum_parallel_output_files;
let mut part_idx = 0;
- let write_id = rand::distr::Alphanumeric.sample_string(&mut rand::rng(),
16);
+ let mut write_id = exec_options.partitioned_file_prefix_name.clone();
Review Comment:
Ha, fair point. Named params solve the immediate problem with zero added
complexity. Works for me.
##########
datafusion/core/src/dataframe/mod.rs:
##########
@@ -73,6 +73,7 @@ use datafusion_functions_aggregate::expr_fn::{
use async_trait::async_trait;
use datafusion_catalog::Session;
+#[derive(Clone)]
Review Comment:
Agreed, nothing wrong with it. It's a plain data struct with no resources or
invariants that cloning would violate. Makes the builder pattern nicer to
work with too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
