rgehan opened a new pull request, #19299: URL: https://github.com/apache/datafusion/pull/19299
## Which issue does this PR close? None, as this PR is rather self-describing. ## Rationale for this change We recently encountered stack overflow issues in the physical planner's `create_physical_expr` function, when dealing with deeply nested expression trees. In the rest of the codebase, it seems the `recursive::recursive` attribute is used to prevent this. ## What changes are included in this PR? This PR adds the `recursive::recursive` attribute on `create_physical_expr` whenever the `recursive_protection` feature is enabled. ## Are these changes tested? Yes, but mostly for the sake of manually testing the change. I don't think it should be merged, as it has to be `#[ignore]`d anyway, as the `recursive_protection` is not enabled in tests (which means it would systematically crash). I've left it in this PR however, to make review / manual testing easier. ## Are there any user-facing changes? None. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
