mkleen commented on code in PR #19302:
URL: https://github.com/apache/datafusion/pull/19302#discussion_r2614999635
##########
datafusion/common/src/stats.rs:
##########
@@ -321,6 +321,13 @@ impl Statistics {
}
}
+ /// Returns the memory size in bytes.
+ pub fn heap_size(&self) -> usize {
+ // column_statistics + num_rows + total_byte_size
+ self.column_statistics.capacity() * size_of::<ColumnStatistics>()
Review Comment:
I hope this makes sense. Since all fields of `ColumnStatistics` are Enums,
`size_of` should account for them correctly. There will be no further heap
allocation for the values T of the `Precision<T>` from `ColumnStatistics`. I
made a few experiments comparing to the results of deep_size.
##########
datafusion/common/src/stats.rs:
##########
@@ -321,6 +321,13 @@ impl Statistics {
}
}
+ /// Returns the memory size in bytes.
+ pub fn heap_size(&self) -> usize {
+ // column_statistics + num_rows + total_byte_size
+ self.column_statistics.capacity() * size_of::<ColumnStatistics>()
Review Comment:
I hope this makes sense. Since all fields of `ColumnStatistics` are Enums,
`size_of` should account for them correctly. There will be no further heap
allocation for the values T of the `Precision<T>` from `ColumnStatistics`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
