alamb commented on code in PR #19296: URL: https://github.com/apache/datafusion/pull/19296#discussion_r2615135867
########## datafusion/sqllogictest/test_files/timestamps.slt: ########## @@ -2867,48 +2871,71 @@ select make_date(t.year, t.month, t.day) from table_strings t; statement ok insert into table_strings values (2024, null, 23); -query error DataFusion error: Execution error: Unable to parse date from 2024, 0, 23 +query D select make_date(t.year, t.month, t.day) from table_strings t; +---- +2024-01-23 +2023-11-30 +NULL statement ok drop table table_strings; -query error DataFusion error: Execution error: Unable to parse date from 2024, 13, 23 +query error DataFusion error: Execution error: Month value '13' is out of range Review Comment: That is a nicer error I think -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
