alamb commented on code in PR #19300:
URL: https://github.com/apache/datafusion/pull/19300#discussion_r2615187197
##########
datafusion/proto/src/physical_plan/to_proto.rs:
##########
@@ -227,6 +228,30 @@ pub fn serialize_physical_expr(
let value = snapshot_physical_expr(Arc::clone(value))?;
let expr = value.as_any();
+ // HashTableLookupExpr is used for dynamic filter pushdown in hash joins.
Review Comment:
it would be nice if we could move the protobuf serialization logic into the
PhysicalExpr trait itself so we don't forget new structures like this
However, given this just follows the existing pattern, i think it looks
good to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
