Tpt commented on code in PR #18993:
URL: https://github.com/apache/datafusion/pull/18993#discussion_r2615461877
##########
datafusion/catalog/src/cte_worktable.rs:
##########
@@ -86,15 +87,23 @@ impl TableProvider for CteWorkTable {
async fn scan(
&self,
_state: &dyn Session,
- _projection: Option<&Vec<usize>>,
- _filters: &[Expr],
- _limit: Option<usize>,
+ projection: Option<&Vec<usize>>,
+ filters: &[Expr],
+ limit: Option<usize>,
) -> Result<Arc<dyn ExecutionPlan>> {
Review Comment:
Sadly the `scan` method does not have a default implementation in the trait
so I have to implement it. I preferred to make it call `scan_with_args` but
glad to do otherwise if you prefer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
