LucaCappelletti94 commented on PR #2077: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2077#issuecomment-3649151018
> Thanks @LucaCappelletti94 and sorry for the delay in getting back to this. I haven't looked at the PR in depth but I think so far I'm not comfortable with the approach as I mentioned previously of mixing in parsing logic into the tokenizer. I think the complexity add is too significant going forward to warrant the pay off I think that it should not be looked as the added complexity of the tokenizer but how much it simplifies the parser. I agree that the duplicated parser context logic is extremely undesirable here in this form. In my opinion the cleanest solution should be to execute tokenization and parsing side-by-side, with the tokenizer refactored so that it can always use the information of what is the current context to optimally execute the tokenization. Of course, such thing is solely needed due to some pattern-breaking non-sql features. Would you prefer such an approach? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
