tobixdev commented on code in PR #18552:
URL: https://github.com/apache/datafusion/pull/18552#discussion_r2617267943
##########
datafusion/expr/src/expr.rs:
##########
@@ -3264,9 +3266,21 @@ impl Display for Expr {
}
Expr::ScalarVariable(_, var_names) => write!(f, "{}",
var_names.join(".")),
Expr::Literal(v, metadata) => {
- match metadata.as_ref().map(|m| m.is_empty()).unwrap_or(true) {
- false => write!(f, "{v:?} {:?}",
metadata.as_ref().unwrap()),
- true => write!(f, "{v:?}"),
+ match metadata.as_ref().and_then(|m| m.logical_type()) {
Review Comment:
Pretty printing for Logical Plan. Could be a bit decluttered / imrpoved but
does it's job for the sake of this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
