petern48 commented on code in PR #19278:
URL: https://github.com/apache/datafusion/pull/19278#discussion_r2617614523
##########
datafusion/functions-aggregate/src/median.rs:
##########
@@ -289,14 +289,31 @@ impl<T: ArrowNumericType> Accumulator for
MedianAccumulator<T> {
}
fn evaluate(&mut self) -> Result<ScalarValue> {
- let d = std::mem::take(&mut self.all_values);
- let median = calculate_median::<T>(d);
+ let median = calculate_median::<T>(&mut self.all_values);
ScalarValue::new_primitive::<T>(median, &self.data_type)
}
fn size(&self) -> usize {
size_of_val(self) + self.all_values.capacity() * size_of::<T::Native>()
}
+
+ fn retract_batch(&mut self, values: &[ArrayRef]) -> Result<()> {
+ let values = values[0].as_primitive::<T>();
+ for v in values.iter().flatten() {
+ if let Some(idx) = self.all_values.iter().position(|x| *x == v) {
Review Comment:
Thanks, I improved it using a hashmap in
https://github.com/apache/datafusion/pull/19278/changes/1b710cc753efafdf529deb3e40760f70a635d896
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
