geoffreyclaude commented on code in PR #19265:
URL: https://github.com/apache/datafusion/pull/19265#discussion_r2618387014
##########
docs/source/library-user-guide/functions/adding-udfs.md:
##########
@@ -1492,7 +1492,9 @@ async fn main() -> Result<()> {
## Custom Expression Planning
-DataFusion provides native support for common SQL operators by default such as
`+`, `-`, `||`. However it does not provide support for other operators such as
`@>`. To override DataFusion's default handling or support unsupported
operators, developers can extend DataFusion by implementing custom expression
planning, a core feature of DataFusion
+DataFusion provides native support for common SQL operators by default such as
`+`, `-`, `||`. However it does not provide support for other operators such as
`@>`. To override DataFusion's default handling or support unsupported
operators, developers can extend DataFusion by implementing custom expression
planning, a core feature of DataFusion.
Review Comment:
Looks great! I just added a `constructs like` to have:
> ... for other operators such as `@>` or **constructs like** `TABLESAMPLE`
...
##########
docs/source/library-user-guide/functions/adding-udfs.md:
##########
@@ -1492,7 +1492,9 @@ async fn main() -> Result<()> {
## Custom Expression Planning
-DataFusion provides native support for common SQL operators by default such as
`+`, `-`, `||`. However it does not provide support for other operators such as
`@>`. To override DataFusion's default handling or support unsupported
operators, developers can extend DataFusion by implementing custom expression
planning, a core feature of DataFusion
+DataFusion provides native support for common SQL operators by default such as
`+`, `-`, `||`. However it does not provide support for other operators such as
`@>`. To override DataFusion's default handling or support unsupported
operators, developers can extend DataFusion by implementing custom expression
planning, a core feature of DataFusion.
Review Comment:
Looks great! I just added a `constructs like` to have:
> ... for other operators such as `@>` or *constructs like* `TABLESAMPLE` ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
