pepijnve commented on code in PR #19287:
URL: https://github.com/apache/datafusion/pull/19287#discussion_r2619044208
##########
datafusion/physical-plan/src/aggregates/row_hash.rs:
##########
@@ -643,6 +674,21 @@ impl GroupedHashAggregateStream {
}
}
+fn find_sort_options(
+ output_ordering: Option<&LexOrdering>,
+ expr: &dyn PhysicalExpr,
+) -> SortOptions {
+ if let Some(ordering) = output_ordering {
+ for e in ordering {
+ if e.expr.as_ref().dyn_eq(expr) {
+ return e.options;
+ }
+ }
+ }
+
+ SortOptions::default()
+}
+
Review Comment:
I wasn't 100% sure about this implementation. Perhaps there's a better (more
elegant) way to figure out what the correct `SortOptions` are.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
