alamb commented on code in PR #19343:
URL: https://github.com/apache/datafusion/pull/19343#discussion_r2620708738
##########
datafusion/physical-expr/src/projection.rs:
##########
@@ -76,7 +76,8 @@ impl std::fmt::Display for ProjectionExpr {
impl ProjectionExpr {
/// Create a new projection expression
- pub fn new(expr: Arc<dyn PhysicalExpr>, alias: String) -> Self {
+ pub fn new(expr: Arc<dyn PhysicalExpr>, alias: impl Into<String>) -> Self {
Review Comment:
this is the actual code change, the rest of the PR is cleaning up callsites
##########
datafusion/core/tests/execution/coop.rs:
##########
@@ -653,7 +653,7 @@ async fn join_agg_yields(
let proj_expr = vec![ProjectionExpr::new(
Arc::new(Column::new_with_schema("value", &input_schema)?) as _,
- "value".to_string(),
+ "value",
Review Comment:
The underlying `ProjectionExpr` is still the same, this PR just makes it
easier to make them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
