Jefffrey commented on code in PR #19350:
URL: https://github.com/apache/datafusion/pull/19350#discussion_r2622995380
##########
datafusion/proto/src/physical_plan/mod.rs:
##########
Review Comment:
Not sure about the changes to this file; can we maintain the previous code
whilst fixing the lints?
##########
datafusion/proto/src/generated/mod.rs:
##########
@@ -15,13 +15,16 @@
// specific language governing permissions and limitations
// under the License.
+#![allow(clippy::allow_attributes)]
+
#[allow(clippy::all)]
#[rustfmt::skip]
pub mod datafusion {
include!("prost.rs");
include!("datafusion_proto_common.rs");
#[cfg(feature = "json")]
+ #[allow(clippy::allow_attributes)]
Review Comment:
Is this not covered by the `#![allow(clippy::allow_attributes)]` above?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
