Dandandan commented on code in PR #19365:
URL: https://github.com/apache/datafusion/pull/19365#discussion_r2625923713
##########
datafusion/physical-plan/src/repartition/mod.rs:
##########
@@ -1042,18 +1042,6 @@ impl ExecutionPlan for RepartitionExec {
&self,
projection: &ProjectionExec,
) -> Result<Option<Arc<dyn ExecutionPlan>>> {
- // If the projection does not narrow the schema, we should not try to
push it down.
Review Comment:
I think this still shows up in the plans, in some cases the number of fields
is bigger before repartitition because of this (and might hurt performance as
`RepartitionExec` copies the input columns (currently twice)). Can we instead
relax the conditition to `>` instead of `>=` so it will be pushed down if it
also keeps the number of fields equal?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
