asolimando commented on PR #19321:
URL: https://github.com/apache/datafusion/pull/19321#issuecomment-3670864541
> @asolimando @pepijnve Thanks for the reviews, I've pushed up a couple of
commits which addresses your feedback to unify the type.
LGTM, not blocking but it might be worth adding a few more test cases:
- Mixed placeholders + literals in WHEN (for simple CASE)
- Example: CASE col WHEN $1 WHEN 100 WHEN $2
- Type coercion conflicts (what if types can't be coerced?)
- Multiple WHEN with different concrete types
- Example: CASE WHEN true THEN 1::INT32 WHEN false THEN 2::INT64 ELSE $1
- Placeholder in base expr with no concrete WHEN
- Example: CASE $1 WHEN $2 THEN 'X' (both untyped)
The test harness is verbose, so I understand if these are too much to add.
Cases 1 and 3 would probably give the most value if you want to add just a
couple.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
