adriangb commented on PR #19389: URL: https://github.com/apache/datafusion/pull/19389#issuecomment-3671670055
> General (and quite minor) comment: wouldn't a list instead of a variadic argument be more explicit on how the arguments are related (first one being the field, the rest being the "path"? That would make sense, I'll see if I can model it that way. As long as it's just as ergonomic for users I don't see why not. But either way I think everything statically type checks right now, so I don't know that it'd be "better" in any way for users even if it's nicer in theory. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
