alamb commented on code in PR #19355:
URL: https://github.com/apache/datafusion/pull/19355#discussion_r2632632630
##########
datafusion/sqllogictest/test_files/case.slt:
##########
@@ -384,8 +384,7 @@ SELECT column2, column3, column4 FROM t;
{foo: a, xxx: b} {xxx: c, foo: d} {xxx: e}
# coerce structs with different field orders,
-# (note the *value*s are from column2 but the field name is 'xxx', as the
coerced
-# type takes the field name from the last argument (column3)
+# should keep the same field values
Review Comment:
These tests now work thanks to @brancz in
- https://github.com/apache/arrow-rs/pull/8871
##########
datafusion/sqllogictest/test_files/struct.slt:
##########
@@ -492,9 +492,18 @@ Struct("r": Utf8, "c": Float64)
statement ok
drop table t;
-query error DataFusion error: Optimizer rule 'simplify_expressions'
failed[\s\S]*Arrow error: Cast error: Cannot cast string 'a' to value of
Float64 type
+statement ok
Review Comment:
These tests now work thanks to @brancz in
- https://github.com/apache/arrow-rs/pull/8871
##########
datafusion/sqllogictest/test_files/spark/hash/crc32.slt:
##########
@@ -81,7 +81,7 @@ SELECT crc32(arrow_cast('Spark', 'BinaryView'));
----
1557323817
-# Upstream arrow-rs issue: https://github.com/apache/arrow-rs/issues/8841
-# This should succeed after we receive the fix
-query error Arrow error: Compute error: Internal Error: Cannot cast BinaryView
to BinaryArray of expected type
+query I
Review Comment:
@Jefffrey fixed them upstream ❤️
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
