andygrove commented on code in PR #2941:
URL: https://github.com/apache/datafusion-comet/pull/2941#discussion_r2633115818
##########
native/core/src/execution/shuffle/shuffle_writer.rs:
##########
@@ -952,8 +940,6 @@ impl ShufflePartitioner for
SinglePartitionShufflePartitioner {
if num_rows >= self.batch_size || num_rows +
self.num_buffered_rows > self.batch_size {
let concatenated_batch = self.concat_buffered_batches()?;
- let write_start_time = Instant::now();
Review Comment:
Removing this one is actually a bug fix rather than an optimiation. The
timer was already being passed into functions that perform the writes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
