Jefffrey commented on code in PR #19315:
URL: https://github.com/apache/datafusion/pull/19315#discussion_r2633399869
##########
datafusion/functions/src/math/log.rs:
##########
@@ -289,6 +294,21 @@ impl ScalarUDFImpl for LogFunc {
if num_args != 1 && num_args != 2 {
return plan_err!("Expected log to have 1 or 2 arguments, got
{num_args}");
}
+
+ // TODO: ScalarValue doesn't support negative scale, remove when it
does
+ // See: https://github.com/apache/datafusion/issues/19354
Review Comment:
```suggestion
```
I was wrong here, see:
https://github.com/apache/datafusion/pull/19385#pullrequestreview-3596442126
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
