Jefffrey commented on code in PR #19372:
URL: https://github.com/apache/datafusion/pull/19372#discussion_r2636873495
##########
datafusion/functions/src/math/log.rs:
##########
@@ -102,32 +102,39 @@ impl LogFunc {
}
}
-/// Binary function to calculate an integer logarithm of Decimal128 `value`
using `base` base
-/// Returns error if base is invalid
fn log_decimal128(value: i128, scale: i8, base: f64) -> Result<f64,
ArrowError> {
- if !base.is_finite() || base.trunc() != base {
+ if !base.is_finite() {
Review Comment:
I think we need to check some of these other error conditions such as base
being non-finite or base being less than 1.0, as I don't think they error on
float version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
