timsaucer commented on PR #19437: URL: https://github.com/apache/datafusion/pull/19437#issuecomment-3678826952
I have another branch where I followed the original design more closely and the trait had all of the byte serialization/deserialization methods, but in the end I think this cleans it up nicely. We have a default implementation that users can lean on / copy if they need to. There is a question of whether the methods need to be `&mut dyn` or if `&dyn` is sufficient. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
