JSOD11 commented on PR #19270: URL: https://github.com/apache/datafusion/pull/19270#issuecomment-3690691601
> If they're both always nullable I think we can leave the function as is, since the default is `nullable = true` One of the goals of the epic seems to be to implement `return_field_from_args` rather than `return_type`. https://github.com/apache/datafusion/issues/19144 The default implementation of `return_field_from_args` calls the `return_type` function ([link](https://github.com/apache/datafusion/blob/d2830b6beddfa83ed606bb447551bb1d79f71c7c/datafusion/expr/src/udf.rs#L633)), meaning that if we do not change the function we'd have to stop `return_type` from returning an error, breaking standardization with the rest of the functions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
