wForget commented on code in PR #2983:
URL: https://github.com/apache/datafusion-comet/pull/2983#discussion_r2646580067
##########
README.md:
##########
@@ -84,6 +84,30 @@ Comet aims for 100% compatibility with all supported
versions of Apache Spark, a
your existing Spark deployments and workflows seamlessly. With no code changes
required, you can immediately harness
the benefits of Comet's acceleration capabilities without disrupting your
Spark applications.
+## Explain and Fallback Configuration
+
+Comet provides several configuration options to help users understand which
parts of a Spark query plan are accelerated natively and when execution falls
back to Spark.
+These options control how fallback information and explain output are
reported, and their behavior may vary depending on the Spark version.
+
+The following configuration properties are commonly used when inspecting
fallback behavior and explain output:
+
+| Configuration | What it does
| Notes |
+|-------------------------------------------|--------------------------------------------------------|--------------------------------------------------------|
+| `spark.comet.explainFallback.enabled` | Reports fallback reasons and
shows an extended explain | No output is produced if there are no fallback
reasons |
Review Comment:
These configurations are already in the [comet configuration
documentation](https://github.com/apache/datafusion-comet/blob/main/docs/source/user-guide/latest/configs.md),
do we need to make this change?
By the way, the comet configuration documentation is automatically generated
by `CometConf.allConfs`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
