Jefffrey commented on code in PR #19497: URL: https://github.com/apache/datafusion/pull/19497#discussion_r2647421664
########## datafusion/common/src/scalar/consts.rs: ########## @@ -17,24 +17,36 @@ // Constants defined for scalar construction. +// Next F16 value above π (upper bound) +pub(super) const PI_UPPER_F16: half::f16 = half::f16::from_bits(0x4249); Review Comment: How/where are these constants sourced from? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
