Jefffrey commented on issue #19322: URL: https://github.com/apache/datafusion/issues/19322#issuecomment-3692888090
> Should median hange its return type for integers (from Int8 → Float64)? This is a breaking change but matches percentile_cont behavior. I think this has been brought up before, though I can't remember which issue off the top of my head. It does sound reasonable to make it mimic percentile_cont instead of being discrete, though it would be good to verify against other DB systems (DuckDB, Postgres, Spark) to understand what they are doing. And a change like that is likely to be it's own issue separate from this overflow issue (perhaps search existing issue list to see if we already raised it). > Or should we only fix the overflow while keeping integer return type? (Promote intermediate calculation to i128 or f64, then cast back) I'd prefer to fix the overflow in this issue only. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
