Nachiket-Roy commented on code in PR #19508: URL: https://github.com/apache/datafusion/pull/19508#discussion_r2649198517
########## datafusion/ffi/tests/utils/mod.rs: ########## @@ -23,6 +23,11 @@ use datafusion_ffi::execution::FFI_TaskContextProvider; use datafusion_ffi::proto::logical_extension_codec::FFI_LogicalExtensionCodec; use datafusion_proto::logical_plan::DefaultLogicalExtensionCodec; +// Creates a default SessionContext and FFI Logical Extension Codec +// for use in FFI integration tests. +// This helper centralizes setup logic and is kept intentionally +// for upcoming FFI test expansions. +#[allow(dead_code)] Review Comment: The helper is used by FFI integration tests, but its usage depends on which tests and features are compiled. In some configurations, the compiler does not see any references to it and therefore does not emit a `dead_code` lint. In those cases, `#[expect(dead_code)]` fails because the lint is not triggered, while `#[allow(dead_code)]` still works since it does not require the lint to be emitted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
