adriangb commented on code in PR #19485:
URL: https://github.com/apache/datafusion/pull/19485#discussion_r2649933098
##########
datafusion/expr-common/src/signature.rs:
##########
@@ -354,6 +356,9 @@ impl TypeSignatureClass {
/// documentation or error messages.
fn get_example_types(&self) -> Vec<DataType> {
match self {
+ // TODO: might be too much info to return every single type here
+ // maybe https://github.com/apache/datafusion/issues/14761
will help here?
Review Comment:
👍🏻
##########
datafusion/sqllogictest/test_files/arrow_typeof.slt:
##########
@@ -95,9 +95,12 @@ SELECT arrow_cast('1', 'Int16')
query error
SELECT arrow_cast('1')
-query error DataFusion error: Execution error: arrow_cast requires its second
argument to be a non\-empty constant string
+query error Expect TypeSignatureClass::Native\(LogicalType\(Native\(String\),
String\)\) but received NativeType::Int64, DataType: Int64
Review Comment:
These are really ugly I agree it would be nice if it was neater. But the
current status quo is not good so this is no better or worse imo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
