alamb commented on code in PR #19431: URL: https://github.com/apache/datafusion/pull/19431#discussion_r2651085722
########## datafusion/sqllogictest/test_files/table_functions.slt: ########## @@ -510,6 +510,277 @@ SELECT c, f.* FROM json_table, LATERAL generate_series(1,2) f; 2 1 2 2 +# To test edge cases related to batch size +statement ok +set datafusion.execution.batch_size = 10; + +# range equal batch size +query I +SELECT * FROM range(10) +---- +0 +1 +2 +3 +4 +5 +6 +7 +8 +9 + +# generate_series equal batch size (including end) +query I +SELECT * FROM generate_series(9) +---- +0 +1 +2 +3 +4 +5 +6 +7 +8 +9 + +# range equal batch size * 2 +query I +SELECT * FROM range(20) +---- +0 +1 +2 +3 +4 +5 +6 +7 +8 +9 +10 +11 +12 +13 +14 +15 +16 +17 +18 +19 + +# generate_series equal batch size * 2 (including end) +query I +SELECT * FROM generate_series(19) +---- +0 +1 +2 +3 +4 +5 +6 +7 +8 +9 +10 +11 +12 +13 +14 +15 +16 +17 +18 +19 + +# range equal batch size with starting value +query I +SELECT * FROM range(1, 11) +---- +1 +2 +3 +4 +5 +6 +7 +8 +9 +10 + +# generate_series equal batch size with starting value (including end) +query I +SELECT * FROM generate_series(1, 10) +---- +1 +2 +3 +4 +5 +6 +7 +8 +9 +10 + +# range equal batch size * 2 with starting value +query I +SELECT * FROM range(1, 21) +---- +1 +2 +3 +4 +5 +6 +7 +8 +9 +10 +11 +12 +13 +14 +15 +16 +17 +18 +19 +20 + +# generate_series equal batch size * 2 with starting value (including end) +query I +SELECT * FROM generate_series(1, 20) +---- +1 +2 +3 +4 +5 +6 +7 +8 +9 +10 +11 +12 +13 +14 +15 +16 +17 +18 +19 +20 + +# range equal batch size with starting value and step +query I +SELECT count(*) FROM range(1, 21, 2) +---- +10 + +# range equal batch size with starting value and step +query I +SELECT * FROM range(1, 21, 2) +---- +1 +3 +5 +7 +9 +11 +13 +15 +17 +19 + +# generate_series equal batch size with starting value and step (including end) +query I +SELECT count(*) FROM generate_series(1, 20, 2) +---- +10 + +# generate_series equal batch size with starting value and step (including end) +query I +SELECT * FROM generate_series(1, 20, 2) +---- +1 +3 +5 +7 +9 +11 +13 +15 +17 +19 + +# range equal batch size * 2 with starting value and step +query I +SELECT count(*) FROM range(1, 40, 2) +---- +20 + +# range equal batch size * 2 with starting value and step +query I +SELECT * FROM range(1, 40, 2) +---- +1 +3 +5 +7 +9 +11 +13 +15 +17 +19 +21 +23 +25 +27 +29 +31 +33 +35 +37 +39 + +# generate_series equal batch size * 2 with starting value and step (including end) +query I +SELECT count(*) FROM generate_series(1, 39, 2) +---- +20 + +# generate_series equal batch size * 2 with starting value and step (including end) +query I +SELECT * FROM generate_series(1, 39, 2) Review Comment: should we also add a test for a starting value other than 1? Perhaps 100 and -100? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
