alamb commented on code in PR #19554:
URL: https://github.com/apache/datafusion/pull/19554#discussion_r2651634183
##########
datafusion/physical-expr/src/expressions/case.rs:
##########
@@ -145,10 +145,13 @@ impl CaseBody {
}
// Construct a mapping from the original column index to the projected
column index.
- let column_index_map = used_column_indices
- .iter()
+ let mut sorted_used_column_indices =
+ used_column_indices.into_iter().collect::<Vec<_>>();
+ sorted_used_column_indices.sort_unstable();
Review Comment:
why does this need to be sorted? Is that some invariant of an older
hashbrown that is no longer true?
##########
Cargo.lock:
##########
Review Comment:
looks like we still have an older hashbrown dependency, but this is a good
step!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
