PhVHoang commented on code in PR #1353:
URL:
https://github.com/apache/datafusion-ballista/pull/1353#discussion_r2652198900
##########
ballista/core/src/execution_plans/distributed_query.rs:
##########
@@ -289,6 +301,8 @@ async fn execute_query(
.max_encoding_message_size(max_message_size)
.max_decoding_message_size(max_message_size);
+ let query_submit_time = std::time::Instant::now();
Review Comment:
Thanks @milenkovicm ,
I think this is a great catch. Using `queued_at` would be more accurate
since it’s a server-side timestamp set by the scheduler when the job is queued.
This avoids client-side clock skew and ensures the measurement doesn’t include
any network latency.
Let me fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
