LiaCastaneda commented on code in PR #19501:
URL: https://github.com/apache/datafusion/pull/19501#discussion_r2652852551
##########
datafusion/functions-aggregate-common/src/min_max.rs:
##########
@@ -501,7 +502,7 @@ impl Accumulator for MinAccumulator {
Ok(self.min.clone())
}
- fn size(&self) -> usize {
+ fn size(&self, _pool: Option<&dyn MemoryPool>) -> usize {
size_of_val(self) - size_of_val(&self.min) + self.min.size()
}
Review Comment:
`MinAccumulator` and `MaxAccumulator` could also use the pool since they
hold a `ScalarValue`, which could hold an Arrow Array --> have shared buffers.
I didn’t do it to avoid adding more changes in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
