askalt commented on PR #19462: URL: https://github.com/apache/datafusion/pull/19462#issuecomment-3699437531
@alamb, Thank you for the feedback! > I wonder if you have considered trying to optimize the re-creation of the plan (e.g optimizing with_new_children for the relevant nodes to avoid recomputing properties when the children have the same properties) It seems this approach implies that we must somehow know that the properties remain unchanged for each particular plan. That sounds much harder to me than extracting state from the plan and not calling `with_new_children` at all -- in other words, avoiding analysis unless it is required. > In general I would really love to help make DataFusion planning (much) faster -- I think we have all the pieces now, but it will take some focused profiling effort to knock down the things that consume time to plan A planning performance boost would make much more sense to me, but in this issue and PR, I am only considering the situation where the plan is already built, optimized, and ready to be reused as an artifact (since re-planning can sometimes run in the background to account for changes in statistics, etc.). What do you think about the introduced feature? Can we move the state out of the plans to make re-execution cheaper? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
