AlyAbdelmoneim commented on code in PR #19515:
URL: https://github.com/apache/datafusion/pull/19515#discussion_r2653329304
##########
datafusion/proto/src/logical_plan/file_formats.rs:
##########
@@ -477,7 +477,9 @@ mod parquet {
force_filter_selections: proto.force_filter_selections,
data_pagesize_limit: proto.data_pagesize_limit as usize,
write_batch_size: proto.write_batch_size as usize,
- writer_version: proto.writer_version.clone(),
+ writer_version: proto.writer_version.parse().expect("
+ Invalid parquet writer version in proto, expected '1.0' or
'2.0'
+ "),
Review Comment:
> We'll probably need to look into this in the future, to change this to a
`TryFrom` instead of having this panic
I left a TODO comment for that now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
