andygrove commented on PR #3014: URL: https://github.com/apache/datafusion-comet/pull/3014#issuecomment-3705552630
> @andygrove , benchmarks supporting ANSI mode had no `Try` check and were failing when I run them on my local. This PR is to essentially add support for ANSI mode so that the flow doesn't error out. I also wanted to see advice and see if I could add changes to add more variety to the benchmarking data in this PR or should we perhaps create a new one ? Disabling ANSI support makes sense for now. We can test the `try_*` methods to test the performance of the validation that happens in ANSI mode. If we want specific benchmarks for ANSI mode then we would need to ensure that we generate input data that will not result in errors. I don't see this is a priority though. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
