coderfender commented on code in PR #3014:
URL: https://github.com/apache/datafusion-comet/pull/3014#discussion_r2658687359
##########
Makefile:
##########
@@ -105,5 +105,35 @@ release-nogit:
./mvnw install -Prelease -DskipTests $(PROFILES)
-Dmaven.gitcommitid.skip=true
benchmark-%: release
cd spark && COMET_CONF_DIR=$(shell pwd)/conf MAVEN_OPTS='-Xmx20g ${call
spark_jvm_17_extra_args}' ../mvnw exec:java -Dexec.mainClass="$*"
-Dexec.classpathScope="test" -Dexec.cleanupDaemonThreads="false"
-Dexec.args="$(filter-out $@,$(MAKECMDGOALS))" $(PROFILES)
+
+# Discover all benchmark classes dynamically
+BENCHMARK_CLASSES := $(shell find
spark/src/test/scala/org/apache/spark/sql/benchmark -name
"Comet*Benchmark.scala" -type f | \
+ xargs grep -l "object.*Benchmark.*extends.*CometBenchmarkBase" | \
+ sed 's|spark/src/test/scala/||g' | \
+ sed 's|/|.|g' | \
+ sed 's|.scala||g' | \
+ sort)
+
+# Run all discovered benchmarks
+benchmark-all:
Review Comment:
Added convenient way to run all benchmark through make file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
