Jefffrey commented on code in PR #19397:
URL: https://github.com/apache/datafusion/pull/19397#discussion_r2659295748
##########
docs/source/library-user-guide/upgrading.md:
##########
@@ -769,31 +769,25 @@ The way schemas are passed to file sources and scan
configurations has been sign
```diff
- let source = ParquetSource::default();
- + let source = ParquetSource::new(table_schema);
+ + let source = ParquetSource::new(TableParquetOptions::default());
Review Comment:
This is still not correct @ShashidharM0118; can you please double check my
comment above? We should not be modifying the existing text in-place under v51
as it is **not** supposed to be in v51, it is meant to be in v52. Moreover
these edits don't make sense; the existing text is left to state:
> **FileSource constructors now require TableSchema**:
But the example has been changed so this is not the case here so now it is
inconsistent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
