waynexia commented on code in PR #19109:
URL: https://github.com/apache/datafusion/pull/19109#discussion_r2670731564
##########
datafusion/core/tests/sql/unparser.rs:
##########
@@ -458,5 +459,8 @@ async fn test_clickbench_unparser_roundtrip() {
#[tokio::test]
async fn test_tpch_unparser_roundtrip() {
+ // Grow stacker segments earlier to avoid deep unparser recursion overflow
in q20.
+ set_minimum_stack_size(512 * 1024);
+ set_stack_allocation_size(8 * 1024 * 1024);
Review Comment:
This case got stack overflow after I rebased against the latest main branch,
and this is a workaround. I'm thinking of rewriting unparser to avoid deep
nested recursion, to some iterative flavor in the follow-up PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
